Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tuner] Remove args.mode #100

Merged
merged 2 commits into from
Aug 22, 2024
Merged

[tuner] Remove args.mode #100

merged 2 commits into from
Aug 22, 2024

Conversation

RattataKing
Copy link
Contributor

@RattataKing RattataKing commented Aug 22, 2024 •
edited
Loading

Remove unused args.mode

@RattataKing RattataKing requested a review from kuhar August 22, 2024 17:31
kuhar
kuhar requested changes Aug 22, 2024
View reviewed changes
Copy link
Member

@kuhar kuhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should drop this option entirely

@RattataKing RattataKing changed the title [tuner] Add CompilationMode class [tuner] Remove args.mode Aug 22, 2024
@kuhar kuhar merged commit 200c3ab into main Aug 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuhar kuhar kuhar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RattataKing @kuhar